Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[core] Decrease size of SymbolBucket #15178

Merged
merged 3 commits into from
Jul 22, 2019
Merged

[core] Decrease size of SymbolBucket #15178

merged 3 commits into from
Jul 22, 2019

Conversation

pozdnyakov
Copy link
Contributor

@pozdnyakov pozdnyakov commented Jul 19, 2019 •
edited
Loading

Decreases sizeof(SymbolBucket) from 2312 bytes to 704 bytes

tag #15022

@pozdnyakov pozdnyakov marked this pull request as ready for review July 19, 2019 13:50
tmpsantos
tmpsantos approved these changes Jul 19, 2019
View reviewed changes
src/mbgl/renderer/buckets/symbol_bucket.hpp
bool dynamicUploaded : 1;
bool sortUploaded : 1;
bool justReloaded : 1;
bool hasVariablePlacement : 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too bad we have 9 bits :-|

@friedbunny friedbunny added Core The cross-platform C++ core, aka mbgl performance Speed, stability, CPU usage, memory usage, or power usage labels Jul 19, 2019
@pozdnyakov
[core] Symbol bucket uses shared layout
a43b807 
sizeof(SymbolBucket): 2296 -> 1024
@pozdnyakov
[core] SymbolBacket creates collision buffers optionally
1fc1b88 
sizeof(SymbolBucket) : 1024 -> 704
alexshalamov
alexshalamov approved these changes Jul 22, 2019
View reviewed changes
Copy link
Contributor

@alexshalamov alexshalamov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@pozdnyakov pozdnyakov merged commit e582a32 into master Jul 22, 2019
@pozdnyakov pozdnyakov deleted the mikhail_shave_symbol_bucket branch July 22, 2019 09:23
@pozdnyakov pozdnyakov self-assigned this Jul 22, 2019
@friedbunny friedbunny added this to the release-queso milestone Jul 22, 2019
@chloekraw chloekraw added the needs changelog Indicates PR needs a changelog entry prior to merging. label Aug 1, 2019
@chloekraw chloekraw removed the needs changelog Indicates PR needs a changelog entry prior to merging. label Aug 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexshalamov alexshalamov alexshalamov approved these changes

@tmpsantos tmpsantos tmpsantos approved these changes

Assignees

@pozdnyakov pozdnyakov

Labels
Core The cross-platform C++ core, aka mbgl performance Speed, stability, CPU usage, memory usage, or power usage
Projects
None yet
Milestone
release-queso
Development

Successfully merging this pull request may close these issues.
5 participants
@pozdnyakov @tmpsantos @alexshalamov @friedbunny @chloekraw