This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Fix tileCover / TileCoordinate fromScreenCoordinate(#15442) #15461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unecessary tile coordinate unproject -> project step. Unproject+project isn't always a noop and this was the issue leading to wrong cover calculation in high pitch values. Fixes: #15442
pozdnyakov
approved these changes
Aug 23, 2019
|
|
||
| LatLng TransformState::screenCoordinateToLatLng(const ScreenCoordinate& point, LatLng::WrapMode wrapMode) const { | ||
| auto coord = screenCoordinateToTileCoordinate(point, 0); | ||
| return Projection::unproject(coord.p, 1 / util::tileSize, wrapMode); |
There was a problem hiding this comment.
nit: 1.0 / util::tileSize
chloekraw
added
the
needs backport
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unecessary tile coordinate unproject -> project step.
Unproject+clamp+project isn't always a noop and this was the issue leading to wrong cover calculation in high pitch values.
Unit test added that exposes the issue.
Fixes: #15442