This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core][Darwin] SDK objects should hold weak pointers to the core style objects #15539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pozdnyakov
force-pushed
the
mikhail_weak_pointer_for_style
branch
2 times, most recently
from
d08776d
to
5a76003
Compare
pozdnyakov
added
bug
Core
julianrex
reviewed
Sep 4, 2019
|
@julianrex Thanks for your comments! considered in the latest commit. |
alexshalamov
approved these changes
Sep 5, 2019
| @@ -6,6 +6,8 @@ | |||
| #include <mbgl/style/types.hpp> | |||
| #include <mbgl/style/conversion.hpp> | |||
|
|
|||
| #include <mapbox/weak.hpp> | |||
|
|
|||
| #include <cassert> | |||
There was a problem hiding this comment.
nit unrelated to this PR: looks like cassert and stdexcept can be removed
julianrex
force-pushed
the
mikhail_weak_pointer_for_style
branch
from
66382ce
to
a804570
Compare
julianrex
added
the
needs changelog
|
@pozdnyakov FYI updated with some tweaks, and an additional test. |
julianrex
removed
the
needs changelog
|
@captainbarbosa can you review the ios/macos bits please? |
captainbarbosa
approved these changes
Sep 9, 2019
… error, rather than raising an exception.
…st for style layers.
julianrex
force-pushed
the
mikhail_weak_pointer_for_style
branch
from
bfe657c
to
8fa33f1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thus, we can avoid crashes caused by dangling raw{Source|Layer} pointer after new style is parsed.
Fixes #15333