Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[android] fix: MapSnapshotter.withApiBaseUri function #15642

Merged
merged 1 commit into from
Sep 18, 2019
Merged

[android] fix: MapSnapshotter.withApiBaseUri function #15642

merged 1 commit into from
Sep 18, 2019

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Sep 17, 2019

cherry-pick of external contributed PR in #15635

cc @Guillaume-TagHeuer

@tobrun tobrun added Android Mapbox Maps SDK for Android needs changelog Indicates PR needs a changelog entry prior to merging. labels Sep 17, 2019
@tobrun tobrun added this to the release-ristretto milestone Sep 17, 2019
@tobrun tobrun requested a review from a team September 17, 2019 12:06
@tobrun tobrun self-assigned this Sep 17, 2019
@tobrun tobrun mentioned this pull request Sep 17, 2019
Closed
LukasPaczos
LukasPaczos approved these changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@LukasPaczos LukasPaczos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should make lint fail when "Variable is assigned to itself" is reported. Wdyt?

@tobrun tobrun merged commit 77420b9 into master Sep 18, 2019
@tobrun tobrun deleted the tvn-cp-15645 branch September 18, 2019 07:19
@tobrun tobrun mentioned this pull request Sep 18, 2019
Merged
@tobrun tobrun mentioned this pull request Mar 6, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LukasPaczos LukasPaczos LukasPaczos approved these changes

Assignees

@tobrun tobrun

Labels
Android Mapbox Maps SDK for Android needs changelog Indicates PR needs a changelog entry prior to merging.
Projects
None yet
Milestone
release-ristretto
Development

Successfully merging this pull request may close these issues.
3 participants
@tobrun @LukasPaczos @guillaumebourderye