Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[core] Suppress network requests for invisible tiles #15741

Merged
merged 3 commits into from
Oct 2, 2019

Conversation

pozdnyakov
Copy link
Contributor

If the render source does not need rendering, we set necessity for its tiles to optional, and thus suppress network requests on tiles expiration.

@pozdnyakov pozdnyakov added bug Core The cross-platform C++ core, aka mbgl labels Oct 2, 2019
@pozdnyakov pozdnyakov self-assigned this Oct 2, 2019
@pozdnyakov pozdnyakov force-pushed the mikhail_no_tile_requests_for_invisible_sources branch from 6d4eb0e to 22bd6eb Compare October 2, 2019 12:22
@pozdnyakov pozdnyakov force-pushed the mikhail_no_tile_requests_for_invisible_sources branch from 22bd6eb to 4004f17 Compare October 2, 2019 12:24
Copy link
Contributor

@alexshalamov alexshalamov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@pozdnyakov pozdnyakov added the needs changelog Indicates PR needs a changelog entry prior to merging. label Oct 2, 2019
If the render source does not need rendering, we set necessity for its tiles to `optional`, and thus suppress network requests on tiles expiration.
@pozdnyakov pozdnyakov force-pushed the mikhail_no_tile_requests_for_invisible_sources branch from fc84b00 to 13a3d5f Compare October 2, 2019 16:03
@pozdnyakov pozdnyakov requested a review from a team October 2, 2019 16:03
@pozdnyakov pozdnyakov removed the needs changelog Indicates PR needs a changelog entry prior to merging. label Oct 2, 2019
@pozdnyakov pozdnyakov merged commit 90b3792 into master Oct 2, 2019
@pozdnyakov pozdnyakov deleted the mikhail_no_tile_requests_for_invisible_sources branch October 2, 2019 17:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Core The cross-platform C++ core, aka mbgl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants