Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[core] Blacklist VAO extension for Adreno (TM) 4xx GPUs #15978

Merged
merged 1 commit into from
Dec 2, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/mbgl/gl/context.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -94,16 +94,16 @@ void Context::initializeExtensions(const std::function<gl::ProcAddress(const cha
}

// Block Adreno 2xx, 3xx as it crashes on glBuffer(Sub)Data
// Block Adreno 4xx as it crashes in a driver when VBOs are destructed (Android 5.1.1)
// Block ARM Mali-T720 (in some MT8163 chipsets) as it crashes on glBindVertexArray
// Block ANGLE on Direct3D as the combination of Qt + Windows + ANGLE leads to crashes
if (renderer.find("Adreno (TM) 2") == std::string::npos
&& renderer.find("Adreno (TM) 3") == std::string::npos
&& (!(renderer.find("ANGLE") != std::string::npos
&& renderer.find("Direct3D") != std::string::npos))
&& renderer.find("Mali-T720") == std::string::npos
&& renderer.find("Sapphire 650") == std::string::npos
&& !disableVAOExtension) {
vertexArray = std::make_unique<extension::VertexArray>(fn);
if (renderer.find("Adreno (TM) 2") == std::string::npos &&
renderer.find("Adreno (TM) 3") == std::string::npos &&
renderer.find("Adreno (TM) 4") == std::string::npos &&
(!(renderer.find("ANGLE") != std::string::npos && renderer.find("Direct3D") != std::string::npos)) &&
renderer.find("Mali-T720") == std::string::npos && renderer.find("Sapphire 650") == std::string::npos &&
!disableVAOExtension) {
vertexArray = std::make_unique<extension::VertexArray>(fn);
}

#if MBGL_USE_GLES2
Expand Down