Counting App Users For Billing #1603
Conversation
…ent when Access Token is set.
…GLEventTypeUserCount to MGLEventTypeAppUserTurnstile
| [MGLMapboxEvents sharedManager]; | ||
| // NOTE: This is (likely) the initial setup of MGLMapboxEvents (via implicit call to +[MGLMapboxEvents sharedManager]) | ||
| // Turn the Mapbox Turnstile to Count App Users | ||
| [MGLMapboxEvents pushEvent:MGLEventTypeAppUserTurnstile withAttributes:nil]; |
There was a problem hiding this comment.
-setAccessToken: can be called more than once. In particular, with #1553, if the developer decides to set the access token programmatically, -setAccessToken: will be called once with nil from within +load and again when the developer gets around to calling +setAccessToken:. You don’t want two turnstile events in that case.
A cleaner approach would be to leave the call to +[MGLMapboxEvents sharedManager] as is and just push a turnstile event at the end of -[MGLMapboxEvents init].
There was a problem hiding this comment.
GTK about the evolving different ways into the SDK. I just moved it to -[MGLMapboxEvents init] and it works great. Thanks!
…ter the strongSelf check
…Events init method to ensure it only gets called once
| if ( ! strongSelf) return; | ||
|
|
||
|
|
||
| if ([MGLEventTypeAppUserTurnstile isEqualToString:event]) { |
There was a problem hiding this comment.
Thanks for taking my earlier feedback into account. Now that I look at this, I’m thinking it would be cleaner to have a separate, specialized method called -pushTurnstileEvent just for this chunk of code (and all the weak/strong/dispatch scaffolding above). You’d call that method from within -init. That way there are no special cases and no possibility of somehow accidentally turning the turnstile more than once.
Not critical though: I think this PR looks good overall.
There was a problem hiding this comment.
I actually like that idea quite a bit. It further separates the Turnstile tick from the stock Events API conceptually as well as gets rid of the "special cases" which tbh wasn't really sitting well with me. 👍
…ucture. Adding event, created, and appBundleId to posted Turnstile Event data model.
For #1595