Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Fixed account type setting; reworded IB designable message #1615

Merged
merged 5 commits into from
May 21, 2015
Merged

Fixed account type setting; reworded IB designable message #1615

merged 5 commits into from
May 21, 2015

Commits on May 21, 2015

  1. Fixed up various Info.plist edge cases 

    Need to look in the main bundle for Info.plist settings, because the developer has no access to the framework’s Info.plist. Need to check MGLMapboxMetricsEnabledSettingShownInApp before MGLMapboxAccessToken; otherwise, `MGLMapboxEvents` inspects the Settings bundle plist before MGLMapboxMetricsEnabledSettingShownInApp is even checked.
    @1ec5
    1ec5 committed May 21, 2015
    Configuration menu
    Copy the full SHA
    70381d2 View commit details
    Browse the repository at this point in the history

  2. Made accessToken uninspectable

    @1ec5
    1ec5 committed May 21, 2015
    Configuration menu
    Copy the full SHA
    c718d2e View commit details
    Browse the repository at this point in the history

  3. Clarified IB designable message 

    Access tokens are only required for showing Mapbox-hosted maps.
    @1ec5
    1ec5 committed May 21, 2015
    Configuration menu
    Copy the full SHA
    e74997e View commit details
    Browse the repository at this point in the history

  4. Rewrote IB designable message 

    IB designables inside frameworks have no access whatsoever to the host app’s bundle (especially if the host app lacks any designables of its own). So it has no way of knowing whether the access token is set in Info.plist. We could continue to check whether it was set programmatically, but we’d still have no way of knowing whether the host app has a Settings bundle, the other prerequisite for displaying Mapbox maps. Therefore, this change removes the Mapbox logo from the designable and displays a reworded reminder unconditionally. It now displays the URL of the “First steps with Mapbox GL for iOS” guide. I kept Mapbox blue in the designable, but as a border, so you can easily tell where the view ends (a major usability problem for custom views in IB).
    @1ec5
    1ec5 committed May 21, 2015
    Configuration menu
    Copy the full SHA
    93f92b7 View commit details
    Browse the repository at this point in the history

  5. Removed unavailable method implementation 

    This class method is marked unavailable in MGLAccountManager.h, so this code can never be reached.
    @1ec5
    1ec5 committed May 21, 2015
    Configuration menu
    Copy the full SHA
    2200c51 View commit details
    Browse the repository at this point in the history