This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Fix offline region download freezing #16230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshalamov
approved these changes
Feb 25, 2020
Downloaded resources are put in the buffer and inserted in the database in batches. Before this change, the buffer was flushed only at the network response callback and thus it never got flushed if the last required resources were present locally and did not initiate network requests -> it caused freezing. Now the buffer is flushed every time the remaining resources container gets empty.
Thus we do not need to include specific headers to use `{set|get}Property`
API with key constants.
pozdnyakov
force-pushed
the
mikhail_fix_offline_download_freezing
branch
from
bd0f50e to
23de1eb
Compare
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downloaded resources are put in the buffer and inserted in the database in batches.
Before this change, the buffer was flushed only at the network response callback
and thus it never got flushed if the last required resources were present locally
and did not initiate network requests -> it caused freezing.
Now the buffer is flushed every time the remaining resources container gets empty.
Fixes https://github.com/mapbox/mapbox-gl-native-team/issues/195