This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Styleable MapSnapshotter #16268
Merged
Styleable MapSnapshotter #16268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshalamov
added
the
needs changelog
You'll find this interesting @mapbox/navigation-ios @mapbox/navigation-android . |
alexshalamov
force-pushed
the
alexshalamov_styleable_snapshotter
branch
from
a06a12d
to
3faae80
Compare
alexshalamov
removed
the
needs changelog
alexshalamov
force-pushed
the
alexshalamov_styleable_snapshotter
branch
2 times, most recently
from
7e91d87
to
cbca768
Compare
Map and renderer / orchestrator should be able to run on a separate threads, however, legacy AnnotationManager is shared between Map and Renderer, therefore is not a thread safe. Until AnnotationManager is deprecated and removed from a code-base, use it only via weak pointers.
alexshalamov
force-pushed
the
alexshalamov_styleable_snapshotter
branch
from
cbca768
to
1229932
Compare
Move renderer to a separate thread while keeping map on a client thread.
alexshalamov
force-pushed
the
alexshalamov_styleable_snapshotter
branch
2 times, most recently
from
6c2e5b5
to
ecc5376
Compare
The clusterProperties contain only few elements at most.
alexshalamov
force-pushed
the
alexshalamov_styleable_snapshotter
branch
from
5c90442
to
341ce4b
Compare
1ec5
reviewed
Mar 12, 2020
| } else { | ||
| style = std::make_pair(false, jni::Make<std::string>(_env, styleURL)); | ||
| snapshotter->setStyleJSON(jni::Make<std::string>(_env, styleURL)); |
There was a problem hiding this comment.
Should this be a call to setStyleURL() rather than setStyleJSON()?
There was a problem hiding this comment.
Ah, this is taken care of in #16286.
Merged
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Styleable MapSnapshotter
This PR provides means of modifying style of a MapSnapshotter. The new API enables several use-cases, such as: adding route overlays, removing extra information (layers) from a base style, adding custom images that are missing from a style.
In a follow-up PR, new constructor for a
MapSnapshottercould be added that takes existingMapas a parameter, so that snapshotter could re-use already created / parsed style.Changes:
MapSnapshotter::cancelmethodAnnotationManagerfrom reference to weak_ptr, as it is owned by a Map, yet, acessed by a renderer.Adaptation for iOS / macOS / Android platforms
iOS / macOS adaptation: https://github.com/mapbox/mapbox-gl-native-ios/compare/alexshalamov_styleable_snapshotter
Android adaptation: in this PR
Launch Checklist
@mapbox/maps-android @mapbox/maps-ios @mapbox/core-sdkif this PR adds or updates a public APIneeds changeloglabel if a changelog is needed (remove label when added)/cc @mapbox/maps-android @mapbox/maps-ios @mapbox/core-sdk