Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Convert point annotations to RTree instead of pre-creating tiles for all zoom levels #1694

Closed
wants to merge 3 commits into from

Conversation

kkaefer
Copy link
Contributor

@kkaefer kkaefer commented Jun 9, 2015

depends on #1695

@kkaefer kkaefer self-assigned this Jun 9, 2015
@kkaefer
Copy link
Contributor Author

kkaefer commented Jun 9, 2015

@incanus, is there any reason we're using integer IDs rather than wrapping a shared_ptr to track annotations for later removal?

@incanus
Copy link
Contributor

incanus commented Jun 9, 2015

is there any reason we're using integer IDs rather than wrapping a shared_ptr to track annotations for later removal?

If annotation adds/removes are synchronous, why bother with the complexity? basically

See also how we map them Cocoa-side, which I suppose could be adapted to live pointers:

@property (nonatomic) NSMapTable *annotationIDsByAnnotation;

@kkaefer
Copy link
Contributor Author

kkaefer commented Jun 9, 2015

why bother with the complexity? basically

We need to maintain a separate mapping of ID to Annotation so we can remove the correct elements from the RTree.

@kkaefer kkaefer force-pushed the 1694-point-annotations-rtree branch from c829d53 to bddbdbb Compare June 10, 2015 15:42
@kkaefer
Copy link
Contributor Author

kkaefer commented Jun 10, 2015

@incanus can you review please?

@incanus incanus added this to the iOS Beta 3 milestone Jun 10, 2015
@incanus
Copy link
Contributor

incanus commented Jul 7, 2015

We're not hitting this as part of b3.

@jfirebaugh
Copy link
Contributor

#2673

@jfirebaugh jfirebaugh closed this Oct 19, 2015
@jfirebaugh jfirebaugh deleted the 1694-point-annotations-rtree branch October 19, 2015 20:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants