This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Fix hardcoded Styles in iOS sample-app #1709
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use api-call „-bundledStyleURLs“ to get style instead of hardcoded array. Now shows Style-Index instead of name.
Create name from filename and display that instead of index.
|
Thanks for the PR. However, the direction we want to go here is to use |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current sample for iOS uses a hardcoded array for styles and because of that offers styles not supported anymore.
I fixed that by using bundledStyleURLs which always returns a current list of available styles.
To keep the UI intact and reasonable pretty I extract a name from the filename.