This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Updates to Map::{renderSync,nudgeTransitions} #1979
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the example in #1975 where a custom animation (not triggered by an input event) triggers a
Map
repaint,Map
should be self-sufficient in terms of data to avoid triggeringView
invalidations in a burst.Important changes:
Map::renderSync()
no longer provides a return parameter.Map::nudgeTransitions()
no longer requires aforceRerender
parameter.MapContext::renderSync()
should be ideally returning void, however for performance reasons we no w only return the value ofMapContext::isLoaded()
to avoid a secondinvokeSync()
fromMap
toMapContext
.Transform::needsTransition()
-Transform::updateTransitions()
already checks for the transition callback.StillImageCallback
to its own header to avoid duplicated definitions inMap
andMapContext
headers.Update::Repaint
enum to notifyMapContext
that all we require is a style update, followed by a view invalidation.MapContext::invalidateView()
to avoid flooding the client with redundant invalidation calls./cc @incanus @kkaefer @jfirebaugh @tmpsantos @tmcw
Fixes #1975.