This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
fixes #1969: support for marker tapping in Android #2201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
incanus
changed the title
|
You know what? Marker picking isn't performance-constrained, so if we can find improvements to the existing annotation iteration in future, feel free to change them. But for now I am going to squash + force push + merge this so we can build on it. |
incanus
force-pushed
the
android-bind-annotation-bounds
branch
from
6632660
to
bcfce80
Compare
incanus
removed
the
⚠️ DO NOT MERGE
|
@incanus There is a function |
|
Ah can't use it anyway because of |
| if (annotation instanceof Marker && idsList.contains(annotation.getId())) { | ||
| annotations.add(annotation); | ||
| } | ||
| } |
There was a problem hiding this comment.
Since mAnnotations is defined using Generics List<Annotation> it can be iterated easier and safer via:
for (Annotation annotation : mAnnotations) {
...
}
Sure it can. Autoboxing. 😃 |
|
@bleege Ah yeah but apparently autoboxing does not happen with arrays. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just logs the marker ID to console right now.
@bleege @ljbade give it a whirl and let me know how it could be better, in particular this routine feels a little wasteful, but I wasn't sure of the best way to make use of
ArrayList.contains()otherwise given along[].We can tune this up possibly, then merge and pick up work in #894 for popups connecting to this.
Another weirdness is a
60x80top two-thirds-weighted hit region felt best on Android as opposed to the40x60we use on iOS. I am making sure to takeMapView.mScreenDensityinto account.