Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Improve transitions in iOS 9 multitasking #2309

Closed
wants to merge 2 commits into from

Conversation

bwhtmn
Copy link
Contributor

@bwhtmn bwhtmn commented Sep 11, 2015

Leave GLview rendering on when app is inactive, to get nice smooth transitions between sizes when using multitasking on iPad (iOS 9).

…ansitions between sizes when using multitasking on iPad (iOS 9).
@1ec5
Copy link
Contributor

1ec5 commented Sep 11, 2015

At the very least, the GL view needs to be inactive in the background on iOS 8.x and below, to avoid regressing #1050, #1186, #1203, #1243, and #1460. (It’s been quite a journey…) Can you verify that those crashes don’t occur in iOS 9?

@1ec5
Copy link
Contributor

1ec5 commented Sep 11, 2015

Ah, I misread the change: you’re only removing the case where the application becomes inactive, not the case where it goes entirely into the background. That’s probably considerably safer.

@1ec5 1ec5 added bug iOS Mapbox Maps SDK for iOS labels Sep 11, 2015
@bwhtmn
Copy link
Contributor Author

bwhtmn commented Sep 11, 2015

Yup, this should apply to situations where the app is temporarily interrupted (e.g. multitasking or a system alert).

According to Apple's docs, you'd ideally want to throttle down the OpenGL frame rate when the app is inactive but I didn't see an easy way to do that.

…rotated while the app was in the background
@incanus
Copy link
Contributor

incanus commented Sep 22, 2015

you'd ideally want to throttle down the OpenGL frame rate when the app is inactive but I didn't see an easy way to do that.

Yeah, this is most commonly done in GLKView with a corresponding GLKViewController (preferredFramesPerSecond), which we don't use because we want to be a standalone view like MKMapView. Not seeing a shortcut way to do this.

@1ec5
Copy link
Contributor

1ec5 commented Nov 9, 2015

Thanks for this PR. An updated version is now being tracked as #2988.

@1ec5 1ec5 closed this Nov 9, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug iOS Mapbox Maps SDK for iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants