Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[android] #2273 - Adjust InfoWindow triangle for edge of screen annotations #2601

Merged
merged 1 commit into from
Oct 14, 2015
Merged

[android] #2273 - Adjust InfoWindow triangle for edge of screen annotations #2601

merged 1 commit into from
Oct 14, 2015

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Oct 13, 2015

closes #2273

@bleege
Copy link
Contributor

bleege commented Oct 13, 2015

One of the Travis build variants (Linux) didn't work. Restarting it to see if it'll take and then we can merge.

@bleege
Copy link
Contributor

bleege commented Oct 13, 2015

This looks like an issue with Node. I've asked @jfirebaugh @mikemorris to 👀 at it. Will hold off on merging until they 👍.

https://travis-ci.org/mapbox/mapbox-gl-native/jobs/85113789

screen shot 2015-10-13 at 11 12 08 am

@bleege
Copy link
Contributor

bleege commented Oct 13, 2015

@jfirebaugh pointed out that this is a known issue with Node right now.

@bleege
Copy link
Contributor

bleege commented Oct 13, 2015

I just tried running the code locally on HTC M9 and saw that while the triangle was moving properly back and forth per pin location on screen, there's a consistent big gap between the top of the Marker and bottom of the InfoWindow Triangle. This occurred both in the MainActivity and PressForMarkerActivity. I also couldn't get the InfoWindowActivity to load... it just showed a black screen but didn't crash. Below are some screenshots:

device-2015-10-13-115810
MainActivity Centered

device-2015-10-13-115836
MainActivity Left

device-2015-10-13-115908
MainActivity Right

device-2015-10-13-120056
PressForMarkerActivity

@bleege bleege mentioned this pull request Oct 13, 2015
Closed
@ljbade
Copy link
Contributor

ljbade commented Oct 13, 2015

Hmm could be related to #2599

@tobrun
[android] #2273 - Added InfoWindowView, Refactored InfoWindow to take…
981ac40 
… in account margins/offset, exposed margin of InfoWindow as configurable
@tobrun tobrun force-pushed the 2273-Adjust-InfoWindow-Triangle-To-Fit-Screen branch from 4b53528 to 981ac40 Compare October 14, 2015 08:21
@tobrun
Copy link
Member Author

tobrun commented Oct 14, 2015

@bleege after reverting master, I'm not seeing these issues anymore:
device-2015-10-14-102653

device-2015-10-14-102740

Waiting for travis to complete before merging

@tobrun
Copy link
Member Author

tobrun commented Oct 14, 2015

Travis approved

@tobrun tobrun merged commit 981ac40 into master Oct 14, 2015
@tobrun tobrun deleted the 2273-Adjust-InfoWindow-Triangle-To-Fit-Screen branch October 14, 2015 08:43
@tobrun tobrun mentioned this pull request Oct 16, 2015
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adjust InfoWindow triangle for edge of screen annotations
4 participants
@tobrun @bleege @ljbade @mourner