This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
fixes #2611: iOS test app long press drops debug marker #2612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks pretty good. Writing some tests, then will merge this.
|
incanus
force-pushed
the
2611-add-default-marker
branch
from
d549f5b
to
e55775c
Compare
|
So jealous of the lovely red marker... |
incanus
force-pushed
the
2611-add-default-marker
branch
from
72c2e44
to
6e1b183
Compare
|
Tests pass locally; Travis testing unreliability problems. Merging. |
This was referenced Oct 16, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this uses our already-present delegate method to just return
nilfor these markers. We still need to hit #2610 (with tests) for the case of not implementing the delegate method.