This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[android] Tidy up annotations API #2651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public long getId() { | ||
| return id; | ||
| } | ||
|
|
||
| public boolean isVisible() { | ||
| boolean isVisible() { |
ljbade
force-pushed
the
2546-min-v2.1.0
branch
from
73dae51
to
babb11b
Compare
|
@bleege Core GL does not currently implement the Also I just remembered that |
ljbade
force-pushed
the
2546-min-v2.1.0
branch
from
babb11b
to
6d29796
Compare
|
Also made methods |
Make unimplemented properties package private. Make annotations object properties immutable. Make InfoWindow and Circle classes package private. Remove no longer needed casts from Options classes. Added a few missing get/add methods to annotations classes for consistency. Mininal version of #2546 suitable for v2.1.0 release.
ljbade
force-pushed
the
2546-min-v2.1.0
branch
from
6d29796
to
1c5bab1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make unimplemented properties package private.
Make annotations object properties immutable.
Make InfoWindow and Circle classes package private.
Mininal version of #2546 suitable for v2.1.0 release.