Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Add make task for building node bindings via Xcode #2688

Merged
merged 3 commits into from
Oct 26, 2015
Merged

Conversation

mikemorris
Copy link
Contributor

Think this should do it @kkaefer.

@mikemorris mikemorris added the Node.js node-mapbox-gl-native label Oct 20, 2015
@mikemorris
Copy link
Contributor Author

Looks like this is grabbing the wrong libuv/node headers, I hit this before testing a pre-release Node version for #2597, workaround was adding the node headers path to include_dirs in binding.gyp IIRC.

Node.js v4.2.1

libc++abi.dylib: terminating with uncaught exception of type std::runtime_error: libuv version mismatch: headers report 0.10.5, but library reports 1.7.5
Abort trap: 6

Node.js v0.12.7

libc++abi.dylib: terminating with uncaught exception of type std::runtime_error│
: libuv version mismatch: headers report 0.10.1, but library reports 1.6.1
Abort trap: 6

@kkaefer
Copy link
Member

kkaefer commented Oct 20, 2015

on node v0.10, it's failing with AttributeError: 'PBXAggregateTarget' object has no attribute ‘FrameworksPhase'. Looks like node-gyp includes -undefined dynamic_lookup in the libraries, which isn't something Xcode likes. Instead, that should be inLDFLAGS`.

@mikemorris mikemorris force-pushed the make-xnode branch 3 times, most recently from 0762773 to 0224ee7 Compare October 20, 2015 21:45
@kkaefer kkaefer force-pushed the make-xnode branch 2 times, most recently from 55693bd to dad6b40 Compare October 26, 2015 16:26
@tmcw
Copy link
Contributor

tmcw commented Oct 27, 2015

@mikemorris for the sake of documentation, why would someone want to run this instead of make node?

@kkaefer
Copy link
Member

kkaefer commented Oct 27, 2015

@tmcw You want to run make xnode so that you have an Xcode project that you can open in Xcode. This helps when debugging code, since you'll get a GUI debugger in the case of a crash.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Node.js node-mapbox-gl-native
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants