This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Rationalize style property classes #2705
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first in a series of PRs that builds towards a full-fledged programmatic style API. This is a big chunk of work, but I'm trying to break it up step by step and not create a long-lived branch with a lot of changes.
Overall, my first major goal is to eliminate
ClassProperties
-- this is essentially an untyped map of every possible style property. Instead, we should work with classes like:These classes already exist, they are just inconsistently named. This PR makes the naming both internally consistent, and consistent with terminology from the style specification: for each layer type, there is a
____PaintProperties
class and a____LayoutProperties
class. For the time being, all of these classes live instyle_properties.hpp
.In code that I touch, I'm also fixing style issues like
&
placement and variable naming conventions. This will be the case with the whole series of PRs.👀 @kkaefer @brunoabinader