This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Remove MapData dependency from StyleParser #2743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfirebaugh
force-pushed
the
style-api
branch
2 times, most recently
from
dd36c83
to
d8460ac
Compare
|
Looks great! 👍 Makes me wonder if we can have a similar class |
This makes subsequent changes to the the parameter list less intrusive.
MapData was needed for two things: getting the default transition and fade durations, and detecting still rendering vs. continuous. The first is avoided by making transition durations optional, and supplying the default fallback value at evaluation time. The second did not fix the still rendering issue, and will be followed up with a different approach in a later commit.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Third in a series of PRs that builds towards a full-fledged programmatic style API. This is a big chunk of work, but I'm trying to break it up step by step and not create a long-lived branch with a lot of changes.
When working on other changes in this series, I found that having a
MapDatadependency in the style parsing code was problematic for other necessary refactoring. The parsing code is low level code that should not have a dependency on high-level objects such asMapData.MapData was needed for two things: getting the default transition and fade durations, and detecting still rendering vs. continuous. This avoids the first by making transition durations optional, and supplying the default fallback value at evaluation time. The second did not fix the still rendering issue, and will be followed up with a different approach in a later commit.
👀 @kkaefer @brunoabinader