This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Improve tvOS build; builds for correct platform, including dependencies. #2778
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to compile for tvOS, Xcode have to be set to 9.1 beta. (sudo xcode-select --switch /Applications/Xcode-beta.app) There are still some errors left to fix.
…with #if's. - Change sdk to appletvos and appletvsimulator. - Remove invalid arm architectures.
Still a linking problem using the system sqlite and and zlib lib mason dependencies.
This was referenced Oct 24, 2015
Closed
This also needs mapbox/mason#122 to update sqlite-system. The machine I was building on had sqlite headers in /usr/include, so I hadn't seen this. I'm updating my tvOS-corvino branches as I find issues to (hopefully) build on clone. Requires switching to tvOS-corvino before initializing submodules, though. |
Cool, we appreciate your efforts here. I think we'll hold off on merging this into the My inclination is to say that you needn't worry about a tvOS benchmark app, but feel free to fiddle with that if you like. |
Closing since we're not likely to merge this in the near term; see #2340 (comment). |
Closed
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is focused around improving the build system to create a tvOS project and build the dependencies for tvOS.
It is working well for my tvOS project. But the app and benchmark problems don't link against the system libs and sqlite properly.
Still quite a lot of progress on the tvOS front. I'd at least like to get feedback before pushing on.
I've tested using the tvOS-corvino branch for this and mason; because mason needs updating, I need extra commits to point mason at my fork. This pull request depends on mapbox/mason#119; I believe together they should provide a working library for tvOS..