This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Wait for style loading, then rotation, then compass fading #2932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the pretty consistent test failures in #2920 by introducing additional waits. We now wait a bit in
-beforeEach(because style and tile loading contributes to sluggishness while rotating), then wait for the map to rotate, then wait for the compass to fade using view-based animation.The wait in
-beforeEachis hard-coded at 500 ms, which is good enough on my machine, but it remains to be seen whether it’s good enough for the CI machines. Ideally I would’ve waited for a-mapViewDidFinishRenderingMap:fullyRendered:callback, but it incorrectly fires after style loading but before tile loading (#2775)./cc @friedbunny @incanus