Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Fix font rendering at the top of the viewport #3057

Closed
wants to merge 2 commits into from

Conversation

kkaefer
Copy link
Member

@kkaefer kkaefer commented Dec 8, 2015

When the map is tilted, glyphs at the top of the viewport are shaded incorrectly:

screen shot 2015-11-17 at 19 32 41

@1ec5 1ec5 added the bug label Nov 17, 2015
@kkaefer kkaefer added the ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold label Dec 8, 2015
@1ec5
Copy link
Contributor

1ec5 commented Dec 18, 2015

Since #3135 landed, the new osxapp obscures the problematic labels by default with a translucent toolbar. You can still see the issue if you hide the toolbar though.

I see that this PR has a “do not merge” label on it – what’s left to do?

@jfirebaugh
Copy link
Contributor

@kkaefer What's left here? Can this be merged?

@jfirebaugh
Copy link
Contributor

It looks like one of the two commits was merged in 2700ea8. @kkaefer, if you want the other commit ("only write shaders if the file content changed"), please rebase and merge in a new PR.

@jfirebaugh jfirebaugh closed this May 20, 2016
@jfirebaugh jfirebaugh deleted the 3057-fix-font-rendering branch May 20, 2016 23:56
@kkaefer
Copy link
Member Author

kkaefer commented May 23, 2016

@jfirebaugh 2700ea8 is no longer necessary, since we're now generating the shaders individually with gyp rules, rather than always writing them.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants