This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
initial featuresAt implementation #3172
Closed
Closed
Changes from 57 commits
Commits
Show all changes
64 commits
Select commit
Hold shift + click to select a range
139b9e7
refs #352: catalog (hardcoded: POI) features on tile parse
incanus b1ad1b6
fix crasher
incanus 8a4f068
refs #352: current state of feature querying
incanus 5de3f99
refs #352: remove unused forward declaration
incanus 3f89f50
refs #352: parse interactive layer property from style
incanus e4f1339
refs #352: further work on featuresAt
incanus 32cb432
refs #352: debug tap coordinate & fix y flip for core
incanus e309fe3
refs #352: remove logging
incanus 7515847
refs #352: hook up `name_en` & normal radius (works for <=z15!)
incanus dc4f5fa
refs #352: naively fetch all feature properties upfront for now
incanus 454c014
refs #352: clean up adds
incanus 8fd4eaf
refs #352: better debug logging
incanus bda6e0c
refs #352: only query clicked tile
incanus cd15d85
refs #352: properly query scale
incanus 29dc55e
refs #352: clean out existing tile feature tree on any sort of re-parse
incanus b1e3da9
refs #352: fix for overzoomed tiles & disable some debug logs
incanus d0a34c5
refs #352: pipe source through the features query
incanus f8fb791
refs #352: typedef feature results for brevity
incanus caa2576
refs #352: naive plumbing of work down into source
incanus fdfb377
refs #352: commenting cleanup
incanus 41159cb
refs #352: public interface cleanup & get rid of unneeded optional/va…
incanus fd4b063
refs #352: cleanups
incanus 181a997
refs #352: add comment
incanus 641e7db
refs #352: move result feature tree directly
incanus ac6ada3
refs #352: clean up extent handling & only add features when valid bbox
incanus 7cdcc49
refs #352: obtain non-string vector tile properties as well
incanus b5f5a24
refs #352: sort result keys at query time as on JS
incanus a9b9568
refs #352: clarify comment
incanus e7b01cd
refs #352: don't clobber debug output properties each loop
incanus d5c31e2
refs #352: fix partial parse symbol layers
incanus 660ff91
refs #352: remove debug log
incanus 22e5c48
refs #352: remove logging & reorganize
incanus 7f6010a
refs #352: build up Cocoa API and remove last of logging
incanus 9824937
refs #352: add Cocoa docs
incanus 91976cb
refs #352: add gesture for feature querying
incanus 2c266e3
refs #352: added interactive style mode to iOS test app
incanus 00339ac
refs #352: removed more extraneous debug stuff
incanus 2a1f0e6
refs #352: pipe through a radius parameter and use 50 on mobile
incanus 0e05c3e
refs #352: add legit iOS feature querying mode
incanus 72ef933
refs #352: return all properties for annotation tiles
incanus b9f47f8
refs #352: move away from interrupting alert
incanus 42741cd
refs #352: remove last debug note
incanus f91df07
refs #352: use actual source max zoom
incanus 0b6953e
refs #352: scroll text area to top when changing contents
incanus 392acd9
refs #352: be more explicit about numeric types and fix tests(?)
incanus 1320df7
refs #352: finally fix tests on Linux by being explicit about numeric…
incanus 0ea4f53
more descriptive & safer public API
incanus b98b686
use defined type
incanus 4c639e5
abstract tile extent 4096 variable
incanus 6c86e78
interactive -> isInteractive
incanus 262665e
boxed literals for UTF8 strings
incanus beda70d
fix bug with storing to reference
incanus 505f929
better, stronger types & more clear method names
incanus b6ad5e2
fix camel case for local variables
incanus d123545
radius uint8_t -> uint16_t as with height & width
incanus ac655ce
better comments, abstract extent, and don't iterate over all loaded t…
incanus 394c484
expose feature query radius in MGLMapView API
incanus 10d36f8
refer to screen points in public API
incanus 6b72663
Merge remote-tracking branch 'origin/master' into 352-featuresAt
incanus d088794
layer is now a pointer
incanus a04b13e
fix getAllValues() for new GeoJSON feature type
incanus 7f07974
getAllValues() -> getValues()
incanus 30239c2
fix Linux narrow warning by using correct type
incanus 02ea849
more POI layers in demo, but cleaner output visually
incanus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
#ifndef MBGL_UTIL_INTERACTIVE_FEATURES | ||
#define MBGL_UTIL_INTERACTIVE_FEATURES | ||
|
||
#include <map> | ||
#include <string> | ||
|
||
namespace mbgl { | ||
|
||
struct FeatureDescription { | ||
inline explicit FeatureDescription(std::string layer_, std::string source_, std::map<std::string, std::string>properties_) | ||
: layer(layer_), source(source_), properties(properties_) {} | ||
|
||
std::string layer; | ||
std::string source; | ||
std::map<std::string, std::string> properties; | ||
}; | ||
|
||
} | ||
|
||
#endif |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should clarify that the distance is measured in screen points, not a physical unit or coordinate delta.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10d36f8