This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uilding MapView's getCameraPosition() and animateCamera().
…g zoom level of CameraActivity a bit more obvious
…CameraActivity to support 3 use cases to align with the 3 animateCamera methods.
…uilding MapView's getCameraPosition() and animateCamera().
…g zoom level of CameraActivity a bit more obvious
…CameraActivity to support 3 use cases to align with the 3 animateCamera methods.
…. Updating MapView.animateCamera() methods to use flyTo().
Merge branch '3244-lightscameraaction' of github.com:mapbox/mapbox-gl-native into 3244-lightscameraaction
…MathUtils class
…) values. Documenting types in CameraOptions. Logging values sent to flyTo from Java.
…lues in flyTo()
…in Transform::flyTo()
…uld be used for calculating desiredZoom. Addresses zero animation use case (by not using it) and animation use case so that the initial fly out animation is rendered.
… animation by removed duration equals zero check. Adding method description documentation.
…Added logic for zero length duration animateCamera calls to use jumpTo() instead of flyTo().
…ethods to match their corresponding methods from GL JS. Removed log statements from debugging.
…s. Updating TestApp's CameraActivity to test for the three different options.
…() UIThread wrapping for Callback invoking. Restoring Callback Toasts in TestApp's CameraActivity.
Bitrise has signed off. Travis is no longer in use for Android. Next step is rebase, test, and merge. |
Rebase was a bit of an adventure. Thanks to @jfirebaugh's help everything has been rebased and squashed into a single commit on |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3244