This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[ios] vary annotation bounds fit padding based on view size #3407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So tiny!
|
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-[MGLMapView showAnnotations:animated:]hardcoded the edge inset to 100 points on all sides, which meant that views with height or width <=200 points would max-zoom into the center point of the bounds, not show the entire bounds.This fix varies the edge padding based on the map view's frame size — if it's less than the default padding, use a fraction of the map view's frame's height/width as inset padding.
Fix #3392, #3110.
/cc @1ec5