This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[android] Use the new camera api instead of hardcoded values #4128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zugaldia
force-pushed
the
4124-offline-activity
branch
from
3c5a261
to
3ed9f43
Compare
| * byte[] utils | ||
| */ | ||
|
|
||
| public static byte[] serialize(Object obj) throws IOException { |
There was a problem hiding this comment.
Since we're removing these utility methods, I think we should revisit #4085 (comment) and consider just using byte[] OfflineRegion::getMetadata().
The TestApp code is probably a good example. The double .getMetadata().getMetadata() looks pretty awkward to me.
String json = new String(offlineRegion.getMetadata().getMetadata(), CustomMetadata.CHARSET);
I think this is better:
String json = new String(offlineRegion.getMetadata(), CustomMetadata.CHARSET);
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4124