This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Fix non-anchored Transform::setAngle #4277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts a line change from b33b2f1, because we explicitely want the anchor to be invalid.
brunoabinader
force-pushed
the
brunoabinader-fix-transform-setangle
branch
from
224de7d
to
694a064
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts a line change from b33b2f1, because we explicitely want
the anchor to be invalid. You were right, @1ec5, when addressing this in https://github.com/mapbox/mapbox-gl-native/pull/4214/files#r55699097 👍
/cc @1ec5 @kkaefer