-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Conversation
d9512dc
to
c3c5fcc
Compare
👀 @jfirebaugh @tobrun @zugaldia @bleege This is a step towards #2909 |
Marking as |
@tmpsantos thank you! @tobrun let's schedule a new battery of tests on Monday? |
Related: #3440 |
@zugaldia we should look into those performance tests we did . These test should be able to give us some extra information about if it's less/more performant by using Traceview. |
Also noting that we want to hold off merging this until after we branch for the 4.0.0 release. |
6ae06dd
to
64d9a71
Compare
64d9a71
to
ea699ec
Compare
Discussed with @tmpsantos in chat and will pick this up now. I'll build it locally to make sure the TestApp works as expected. From there I'll rebase and make sure CI is happy. |
Local tests worked great! I'm going to rebase now and push back to the branch so that we can run the CI on it before merging back to master. |
Rebased, but the only way to push to GitHub required a |
All CI save the Android build passed. Will explore. |
Error turned out to be the following. Will try to resolve locally and push again for CI.
|
As best I can tell some other C++ configs shifted between when @tmpsantos first wrote his 3 commits and now. To rule out a possible messed up rebase and merge, I created a new branch based off |
Give me a second and I'll be available to fix this up. |
Forgot to mention that my test branch is called https://github.com/mapbox/mapbox-gl-native/commits/3440-replace-libuv |
Also implement a Timer and AsyncTask based on Android's Looper.
Needed because Looper could be used by Java and it would crash complaining that we didn't detach otherwise.
Build using Looper instead, provided by the NDK.
a4ad941
to
4b05705
Compare
Got it fixed and merged! |
Ah ha! Libuv had to also be turned off in |
Looper ships with Android and can provide the same functionality.