This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] Stop offline download at tile limit #4343
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -49,7 +49,8 @@ class OfflineDownload { | |||
| */ | |||
| void ensureResource(const Resource&, std::function<void (Response)> = {}); | |||
| void ensureTiles(SourceType, uint16_t, const SourceInfo&); | |||
|
|
|||
| bool hasExceededTileCount(const Resource& resource); | |||
There was a problem hiding this comment.
This method has side effects, but hasExceededTileCount sounds like the name of a pure function. How about checkTileCountLimit?
|
Good catch! You're completely correct about the logic here. In addition to the code adjustment, we should add a regression test. Want to give that a shot? |
|
@boundsj The test and implementation changes look great. I checked them out locally and verified that the test fails before the change and passes after. 🚢 |
|
Thanks @jfirebaugh. Thanks for pointing out how the tests can hang, too. I made sure the new test will fail (and not hang in the run loop) if the required implementation is removed. |
The tile limit guard (when used) stops a download from continuing when the tile limit is reached. This wraps the guard in a method and employs it in both places currently necessary to ensure the guard has a chance to function. Tests have been updated to ensure the fix works for a less trivial tile limit scenario.
boundsj
force-pushed
the
boundsj-stop-download-at-time-limit
branch
from
be7bae0 to
0233b66
Compare
|
Merged in bcb3bb0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tile limit guard (when used) stops a download from continuing when the tile limit is reached. This wraps the guard in a method and employs it in both places currently necessary to ensure the guard has a chance to function.
cc @jfirebaugh @1ec5