This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] [Qt] Avoid NaNs in TransformState unit conversions #5074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoabinader
added
bug
Core
brunoabinader
force-pushed
the
brunoabinader-transformstate-zero-size
branch
from
3dece87 to
228238b
Compare
| @@ -84,7 +84,7 @@ class TransformState { | |||
| NorthOrientation orientation = NorthOrientation::Upwards; | |||
|
|
|||
| // logical dimensions | |||
| uint16_t width = 0, height = 0; | |||
| uint16_t width = 1, height = 1; | |||
There was a problem hiding this comment.
Any unsigned number != 0. Either this or we could go the other way and use std::numeric_limits::max.
There was a problem hiding this comment.
I think this fixes #1572 (unless we go the std::numeric_limits::max route).
brunoabinader
force-pushed
the
brunoabinader-transformstate-zero-size
branch
3 times, most recently
from
3ebe157 to
5431c2d
Compare
brunoabinader
changed the title
brunoabinader
force-pushed
the
brunoabinader-transformstate-zero-size
branch
from
5431c2d to
00dd3ab
Compare
Fix cases where e.g. state has either zero width or height, causing the unit convertion functions would return NaNs.
brunoabinader
force-pushed
the
brunoabinader-transformstate-zero-size
branch
from
00dd3ab to
f751d2c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cases where e.g. state has either zero width or height, causing the unit conversion functions to return NaNs.
👀 @kkaefer @jfirebaugh @ansis