This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Make annotation views accessible to VoiceOver #5235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
added
bug
iOS
|
👍 |
Corrected the accessibility frames of annotation views to match the views’ bounds instead of the bounds of the default annotation image (which could be empty if no default GL point annotation has been added). Fixes #5038.
Annotation views now serve as their own accessibility elements. The developer’s own subclass of MGLAnnotationView can customize the view’s accessibility frame and/or path to more accurately reflect the visual hit target.
1ec5
force-pushed
the
1ec5-a11y-annotation-view-5038
branch
from
a4eb5cb
to
1f622fe
Compare
1ec5
changed the title
|
I’ve redone the PR to use annotation views themselves as their own accessibility elements. |
|
👍 |
1ec5
added a commit
that referenced
this pull request
Jun 7, 2016
Fixed a write-without-read analyzer warning introduced in #5235.
1ec5
added a commit
that referenced
this pull request
Jun 7, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected the accessibility frames of annotation views to match the views’ bounds instead of the bounds of the default annotation image (which could be empty if no default GL point annotation has been added).
Ideally, we’d figure out how to make the annotation view its own accessibility element, so that it or a subclass can specify a custom frame or Bézier path. But I’m punting on that for now to keep things simple.Annotation views are now their own accessibility elements. A subclass can define a custom accessibility path.Fixes #5038.
/cc @boundsj @friedbunny