This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
*Tile ↔ *TileData #5320
Merged
*Tile ↔ *TileData #5320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfirebaugh
force-pushed
the
5143-refactor-tile-source
branch
2 times, most recently
from
01f5f73
to
35e5034
Compare
Tile is now the main base class; RasterTile, VectorTile, etc are its subclasses. GeometryTileData and its subclasses form the piece that's passed to the worker.
jfirebaugh
force-pushed
the
5143-refactor-tile-source
branch
4 times, most recently
from
6a8bf7e
to
b9be5fd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More followup to #5143 and preparation for runtime source API / cross-source label placement / other source related enhancements.
The major change in this PR is swapping the names of
*Tileand*TileDataclasses.Tileis now the main base class;RasterTile,VectorTile, etc are its subclasses.GeometryTileDataand its subclasses form the piece ofTilethat's passed to and from the worker.cc @kkaefer