Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

5427 marker view flat bug #5449

Merged
merged 1 commit into from
Jun 24, 2016
Merged

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Jun 23, 2016

closes #5427

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Jun 23, 2016
@tobrun tobrun added this to the android-v4.1.0 milestone Jun 23, 2016
@@ -163,8 +163,6 @@ public boolean onMarkerClick(@NonNull Marker marker, @NonNull View view, @NonNul
.icon(IconFactory.getInstance(mMapView.getContext())
.fromResource(R.drawable.ic_arsenal))
);

mMapboxMap.getUiSettings().setFocalPoint(new PointF(mMapView.getMeasuredWidth() / 2, mMapView.getMeasuredHeight() / 4));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tobrun Did you intend to remove this line?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that was an artefact of implementing #4924.

@tobrun
Copy link
Member Author

tobrun commented Jun 23, 2016

@zugaldia I moved the initial tilt value setup to another place in the code (not longer a part of the high trafficking code in MarkerVIewManager.update() but as part of MarkerView.setMapboxMap()

@zugaldia
Copy link
Member

@tobrun Sounds good, good catch on the JNI call. I'll merge it now.

@zugaldia zugaldia force-pushed the 5427-MarkerView-flat-bug branch from 8837ff5 to dbd2b6d Compare June 24, 2016 12:59
@zugaldia zugaldia force-pushed the 5427-MarkerView-flat-bug branch from dbd2b6d to 64da7fa Compare June 24, 2016 13:15
@zugaldia zugaldia merged commit 64da7fa into release-android-v4.1.0 Jun 24, 2016
@zugaldia zugaldia deleted the 5427-MarkerView-flat-bug branch June 24, 2016 13:31
@zugaldia zugaldia mentioned this pull request Jun 24, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants