This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[ios] Add simulator dSYM file to build output. #5740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@boundsj, thanks for your PR! By analyzing the annotation information on this pull request, we identified @1ec5, @incanus and @frederoni to be potential reviewers |
| if [[ -e ${PRODUCTS}/${BUILDTYPE}-iphoneos/${NAME}.framework.dSYM ]]; then | ||
| cp -r ${PRODUCTS}/${BUILDTYPE}-iphoneos/${NAME}.framework.dSYM \ | ||
| ${OUTPUT}/dynamic/ | ||
| fi | ||
| step "Copying simulator dSYM" | ||
| if [[ -e ${PRODUCTS}/${BUILDTYPE}-iphonesimulator//${NAME}.framework.dSYM ]]; then |
|
👍 |
|
Instead of copying and bundling two dSYMs, we should be able to lipo/libtool the two dSYM binaries together into one Mapbox.framework.dSYM that includes all of the architectures — I’ll fiddle with this. |
boundsj
force-pushed
the
boundsj-include-simulator-dsym
branch
from
52d912b
to
f18f742
Compare
|
So it is possible to combine the two dSYMs: ... the resulting dSYM binary filesize is also the sum of both, though. |
|
Pushed |
|
Remember to add a blurb to the changelog. |
Our release builds for device (with lipoed simulator binary) create a dSYM files for both the device and simulator. However the script only copied the device dSYM file to the output location. This adds a step to lipo together both the device and simulator dSYM files. Mapbox.framework.dSYM now holds armv7 and arm64 slices.
boundsj
force-pushed
the
boundsj-include-simulator-dsym
branch
from
7ffcaad
to
64a06dd
Compare
friedbunny
pushed a commit
that referenced
this pull request
Oct 28, 2016
Our release builds for device (with lipoed simulator binary) create a dSYM files for both the device and simulator. However the script only copied the device dSYM file to the output location. This adds a step to lipo together both the device and simulator dSYM files. Mapbox.framework.dSYM now holds armv7 and arm64 slices.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5726
Our release builds for device (with lipoed simulator binary) create a dSYM files for both the device and simulator. However the script only copied the device dSYM file to the output location.
This adds a step to create a dSYM file with all relevant architectures.
cc @1ec5 @incanus