Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

fixes #5810: post animateCamera()/easeCamera() callbacks on main thread #5834

Closed
wants to merge 1 commit into from

Conversation

incanus
Copy link
Contributor

@incanus incanus commented Jul 29, 2016

Naive approach here based on my experience, but I think that it's correct. Please tell me it really is this simple!

/cc @bleege @zugaldia @cammace @ivovandongen

@incanus incanus added the Android Mapbox Maps SDK for Android label Jul 29, 2016
@incanus incanus added this to the android-v4.2.0 milestone Jul 29, 2016
@ivovandongen
Copy link
Contributor

@incanus Let's discuss this first on Monday. There is more to this than reported in #5810 as I described and am working on in #5721.

@incanus
Copy link
Contributor Author

incanus commented Jul 30, 2016

Sounds good—figured, as with threading issues almost all of the time, that it's more complex than first blush.

@ivovandongen
Copy link
Contributor

@incanus There's actually more going on still. Just created an activity to re-create the issue and ran into a stack overflow exception. I'm going to make a separate ticket for that as well so we can discuss the root cause.

@incanus
Copy link
Contributor Author

incanus commented Aug 1, 2016

After offline discussion with @bleege @ivovandongen, broader context here is that with rendering on the main thread now, this shouldn't be an issue as such and this PR is irrelevant. We may still yet have race condition issues around state and clearing internal cyclical callbacks, e.g. #5836, but something like what is proposed here purely in Java land does not need to be happening.

@incanus incanus closed this Aug 1, 2016
@incanus incanus deleted the 5810-map-animate-callback-main-thread branch August 1, 2016 16:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants