Add solution for shape overlays to cross antimeridian #6043
Conversation
This adds two tests: AntimeridianAnnotationSmall: Test that a shape that is represented with +-180 longitudinal values is drawn spanning the antimeridian. In other words, it is rendered as a "small" shape as opposed to one that spans around the world to reach the other side of the antimeridian. This test is currently failing at the time of this commit. AntimeridianAnnotationLarge: Test that a shape that is represented with points that do not cross the +-180 boundary is rendered as a "large" shape. In other words, it is rendered by wrapping around the world to reach the other side of the meridian. This test is currently passing at the time of this commit.
boundsj
added
feature
tests
⚠️ DO NOT MERGE
|
@boundsj, thanks for your PR! By analyzing this pull request, we identified @jfirebaugh, @1ec5 and @tmpsantos to be potential reviewers. |
|
The diff in the new
|
|
This looks related: #5600 |
|
Another observation: the full triangle is drawn when we duplicate each polyline coordinate with its 360 degrees negative counterpart, so the following workaround draws the full small triangle: mbgl::Polygon<double> polygon = {{
{{ { 190, 0 }, { 170, 10 }, { 170, -10 } }},
{{ { -170, 0 }, { -190, 10 }, { -190, -10 } }}
}}; |
|
The triangle bug above will be fixed by mapbox/geojson-vt-cpp#57 |
|
Cherry-picked this commit in #6088 with a minor update to the expectation from |
boundsj
changed the title
boundsj
removed
the
⚠️ DO NOT MERGE
#4974 points out how GL Native cannot support a shape overlay that crosses the antimeridian. This PR is to provide support that use case by:
The change in core should be a continuation of the work done in 026b6d4 which fixed several issues related to points surrounding the antimeridian but removed support for expressing shapes crossing the antimerdian with longitudinal values +-180º.