Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[android] #6083 - add circle example #6086

Merged
merged 3 commits into from
Aug 29, 2016
Merged

[android] #6083 - add circle example #6086

merged 3 commits into from
Aug 29, 2016

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Aug 19, 2016

Refs #6083,
add circle example
Review @ivovandongen

@tobrun tobrun added Android Mapbox Maps SDK for Android ✓ ready for review labels Aug 19, 2016
@tobrun tobrun added this to the android-v4.2.0 milestone Aug 19, 2016
@mention-bot
Copy link

@tobrun, thanks for your PR! By analyzing this pull request, we identified @bleege and @zugaldia to be potential reviewers.

@tobrun
Copy link
Member Author

tobrun commented Aug 19, 2016

In this PR i'm adding a new feature activity to the test application. This activity is automatically picked up by our auto sanity test generation tool and now fails in firebase test lab with the following exception:

screen shot 2016-08-19 at 13 12 59

This happens since the sanity test will wait for OnMapReadyCallback to be called. This is validated by the test by checking if mapboxMap instance in your Activity is filled up. In this PR I didn't add an mapboxMap class member to CircleLayer. After adding that the test will pass.

cc @mapbox/android

@ivovandongen
Copy link
Contributor

LGTM. Little documentation on the Activity class wouldn't be out of place though:

@zugaldia
Copy link
Member

This is the new activity, looking good @tobrun :

video

@ivovandongen
Copy link
Contributor

@tobrun Thanks for adding the documentation!

@tobrun tobrun merged commit ed431c9 into master Aug 29, 2016
@tobrun tobrun deleted the 60830-add-circle branch August 29, 2016 11:18
@tobrun
Copy link
Member Author

tobrun commented Aug 29, 2016

cc @mapbox/android

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants