This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[core] refactor to use vector-tile@1.0.0-rc4 #6165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
springmeyer
added
refactor
⚠️ DO NOT MERGE
|
@springmeyer, thanks for your PR! By analyzing this pull request, we identified @jfirebaugh, @incanus and @ansis to be potential reviewers. |
springmeyer
force-pushed
the
standalone-vector-tile-library
branch
2 times, most recently
from
e208c9d to
ec29349
Compare
| FeatureType type = FeatureType::Unknown; | ||
| packed_iter_type tags_iter; | ||
| packed_iter_type geometry_iter; | ||
| feature_type tile_feature; |
There was a problem hiding this comment.
gl-native uses camel case for core variable names, so tileFeature.
|
Per voice with @jfirebaugh - next steps here:
|
springmeyer
force-pushed
the
standalone-vector-tile-library
branch
from
ab4348e to
78263d5
Compare
|
Closing as stale; @springmeyer feel free to reopen or resubmit when you loop back to this. |
|
👍 @jfirebaugh I've got a revised PR locally I've been working on. Will resubmit when its ready. |
|
Finally landed in #9312 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts integrating the first release candidate series of https://github.com/mapbox/vector-tile. This is not intended to merge yet, but rather offer a first working version for discussion.
The ultimate goal is to depend on a standalone library for code related to vector tile decoding. This standalone library will be heavily tested and performance benchmarked.