This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
avoid altering annotation view transforms set by user #6166
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I unearthed a bug where trying to set an annotation view
transform
of your own gets rapidly reset nearly every frame while annotation viewcenter
is changing due to theCATransform3DIdentity
that is repeatedly set in oursetCenter:
override.One case this doesn't cover is when you do have draggable views but still want to set a
transform
. Perhaps we could create an alternate setter calledsetCenterDuringAnnotationUpdate:
which is called by-[MGLMapView updateAnnotationViews]
to bypass any of this drag-relatedtransform
setting entirely?@1ec5 @friedbunny @boundsj