This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
make most headers private #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What do we consider the 'public' API? Just Map and any classes needed for it's public functions (from the first block with comments, assuming the second uncommented public block is for internal use only). |
|
Off the top of my head: Map, View, style-related stuff, and basic geo stuff like LatLng. |
jfirebaugh
added a commit
that referenced
this pull request
Nov 27, 2014
It was an attempt to obtain runtime libuv version independence that turned out to be impossible. More thorough header privatization is tracked in #622
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only a small subset of headers should be publicly accessible -- those that form the public API for mapbox-gl-native. Everything else should live in
src. Where necessary we should add forward declarations or use the pimpl idiom to hide implementation details and avoid public headers including private headers.