Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Clarify MGLGeoJSONSource option units in API docs #6411

Merged
merged 1 commit into from
Sep 21, 2016

Conversation

boundsj
Copy link
Contributor

@boundsj boundsj commented Sep 21, 2016

Fixes: #6236

@mention-bot
Copy link

@boundsj, thanks for your PR! By analyzing this pull request, we identified @1ec5 and @friedbunny to be potential reviewers.

@boundsj boundsj added the iOS Mapbox Maps SDK for iOS label Sep 21, 2016
@boundsj boundsj added this to the ios-v3.4.0 milestone Sep 21, 2016
@boundsj boundsj self-assigned this Sep 21, 2016
Copy link
Contributor

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits, nothing showstopping.

@@ -15,16 +15,16 @@ extern NSString * const MGLGeoJSONClusterOption;

/**
An `NSNumber` object containing an integer; specifies the radius of each
cluster when clustering points, measured in <sup>1</sup>/<sub>512</sub>ths of a
tile. The default value is 50.
cluster if clustering is enabled. A value of 512 indicates a radius equal to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: s/indicates/produces

`MGLGeoJSONMaximumZoomLevelOption`, so that at the last zoom level, the
features are not clustered.
which to cluster points if clustering is enabled. Defaults to one zoom level
less than the value of `MGLGeoJSONMaximumZoomLevelOption` so that, at the last
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you’re here: s/last zoom level/maximum zoom level/ to avoid confusion with “previous zoom level”.

@boundsj boundsj force-pushed the boundsj-clarify-option-units branch from 8425316 to d0db147 Compare September 21, 2016 02:58
@boundsj boundsj merged commit f4ba92a into master Sep 21, 2016
@boundsj boundsj deleted the boundsj-clarify-option-units branch September 21, 2016 16:50
@boundsj boundsj changed the title [ios, macos] Clarify MGLGeoJSONSource option units in API docs Clarify MGLGeoJSONSource option units in API docs Sep 21, 2016
@boundsj boundsj added macOS Mapbox Maps SDK for macOS documentation labels Sep 21, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants