preserve tile query params

[mapsam]

Preserves any custom parameters for the Tile URL, strip out the first parameter (access token) and append the rest back into the tile URL, if they exist.

cc @jakepruitt @jfirebaugh @incanus

[mention-bot]

@mapsam, thanks for your PR! By analyzing this pull request, we identified @jfirebaugh, @tmcw and @yhahn to be potential reviewers.

[mapsam]

Btw, this assumes an access token will always be first, which is probably not a good thing.

[mapsam]

Updated the PR to search specifically for access_token anywhere in the query, remove it, and rebuild the query to be added to the final tile URL.

[jfirebaugh]

Have you had a look at the test failures? Looks like this is not quite doing what you expect.

[mapsam]

This line assumes there is a second parameter by checking for query.find("&", accessTokenIdx). If the response from this is 0, we need to grab the end of the query for accessTokenEndIdx.

[mapsam]

@jfirebaugh yep, tests were indeed failing. I've updated the URL work to use a std::regex instead as well as added some tests to Mapbox.CanonicalURL to check for different orders of URL parameters.

[mapsam]

@jfirebaugh any chance I could get a review here? Much appreciated!

[mapsam]

Thank you @jfirebaugh!