fix #6379: beef up runtime styling manual tests #6433

incanus · 2016-09-22T18:50:50Z

Work in progress to test filtered fills & lines.

mention-bot · 2016-09-22T18:50:53Z

@incanus, thanks for your PR! By analyzing this pull request, we identified @1ec5, @friedbunny and @boundsj to be potential reviewers.

incanus · 2016-09-22T19:38:38Z

Got some examples bolted in for styling fills & lines using filters. Both feature Studio-created layers that are well under the normal map layers, showing off some of our runtime styling flexibility.

Map with states fill layer: fill in Texas

Map with counties line layer: restyle all Washington counties

Other than some minor flickering upon styling, things look good.

Next up is adding a numeric-type filter test to flex #6040 and the Android side.

1ec5 · 2016-09-22T20:51:25Z

platform/ios/app/MBXViewController.m

+    [self.mapView setCenterCoordinate:CLLocationCoordinate2DMake(31, -100) zoomLevel:3 animated:NO];
+
+    // after slight delay, fill in Texas
+    dispatch_after(dispatch_time(DISPATCH_TIME_NOW, (int64_t)(2 * NSEC_PER_SEC)), dispatch_get_main_queue(), ^


A hard-coded timeout would be unfortunate. We don't have a completion block–based way to set the style; in the meantime, you can do this in -mapViewDidFinishLoading: or the forthcoming -mapView:didFinishLoadingStyle: (#6412) perhaps.

It splits functionality up fairly crappily, but I see your point.

#6386 (comment) would mitigate this pain considerably, but it’s aways off.

Looked into this with a patch such as the following:

https://gist.github.com/1ab15bce31631f5ba032a731bd0bed38

However, it happens too quickly, essentially immediately after the style finishing tiling in, causing continual flashing between that happening and then the filter style changes. I want to eliminate the possibility that anything is done as part of the initial style fill, hence the delay so that the user can clearly see things in one state, then the other, to confirm that the filtered styling is applied without any external tile refreshing happening.

OK, in that case, can you document the reasoning here? Now that we’re getting the style from a local resource, I’m not as concerned about the time it’ll take to load it, but someone using iosapp as a learning resource shouldn’t be misled into thinking this is how you use the runtime styling API normally.

89bfeaa88eec7840ecee64c15f22e34d7f6bcbdf

1ec5 · 2016-09-22T20:52:57Z

platform/ios/app/MBXViewController.m

+- (void)styleFilteredFill
+{
+    // set style and focus on Texas
+    [self.mapView setStyleURL:[NSURL URLWithString:@"mapbox://styles/justin/citc7ya7w00002jpa0z16cjah"]];


This will only work with your access token, not the access token that the user enters. Instead, check in the style JSON as part of this project and refer to the bundled JSON file with a file URL or relative path.

63cdd45580602e9a7206dd6d39a76fd2a40887e4

1ec5 · 2016-09-22T20:55:09Z

platform/ios/app/MBXViewController.m

+        MGLFillStyleLayer *regionsLayer = (MGLFillStyleLayer *)[self.mapView.style layerWithIdentifier:@"regions"];
+
+        // filter
+        regionsLayer.predicate = [NSCompoundPredicate andPredicateWithSubpredicates:@[


This can be expressed as a single predicate format string using the AND operator.

c3c9ca40aece3b08b9e63c2a13030e469452a845

boundsj · 2016-09-22T23:39:09Z

Thanks for doing this. While you are at it, I think it'd be great to add cases for the soon to land #6316 to exercise tile template URLs and also something to cover styling 3rd party vector (and raster) source layers. Support for the later was added in the fix for #6251. A single example can cover this (see #6316 (comment))

incanus · 2016-09-23T00:14:49Z

Got this pretty well set on the Android side too.

@boundsj On the ones you mention, is it more useful to visually test the functionality or to just confirm that something happens? i.e. I'm wondering how much we can push that to automated tests. The things I'm doing here are specifically things that won't ever throw or error, but might not look right if a bug crept in.

incanus · 2016-09-23T00:15:13Z

boundsj · 2016-09-23T00:21:38Z

@incanus might not look right if a bug crept in

I think that definition covers a lot of runtime styling cases including what I suggested. For example the MGLTileSet class that will be introduced in #6316 has its own set of options that affect how the map looks. Feel free to ignore my suggestion though if you don't see value in adding that case at this time.

incanus · 2016-09-23T00:48:07Z

Squashed and force pushed. This 🚢 will be ready to ⛵ once tests pass.

incanus · 2016-09-23T01:07:11Z

Ugh, fixing Android local style JSON also first.

incanus added iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS Android Mapbox Maps SDK for Android tests ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold runtime styling labels Sep 22, 2016

incanus added this to the ios-v3.4.0 milestone Sep 22, 2016

incanus self-assigned this Sep 22, 2016

1ec5 suggested changes Sep 22, 2016

View reviewed changes

incanus mentioned this pull request Sep 22, 2016

Paint properties should take effect immediately #6435

Closed

incanus removed ⚠️ DO NOT MERGE Work in progress, proof of concept, or on hold macOS Mapbox Maps SDK for macOS labels Sep 23, 2016

1ec5 approved these changes Sep 23, 2016

View reviewed changes

incanus force-pushed the ios-android-runtime-styling-beefy branch from b15ca3e to 6daa62e Compare September 23, 2016 00:47

incanus force-pushed the ios-android-runtime-styling-beefy branch from 6daa62e to 89bfeaa Compare September 23, 2016 00:51

[ios, android] add visual tests for fill, line, & numeric filter styling

b846f54

incanus force-pushed the ios-android-runtime-styling-beefy branch from 89bfeaa to b846f54 Compare September 23, 2016 01:14

incanus merged commit 6aa00af into master Sep 23, 2016

incanus deleted the ios-android-runtime-styling-beefy branch September 23, 2016 17:13

incanus mentioned this pull request Sep 23, 2016

beef up runtime styling test cases #6379

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix #6379: beef up runtime styling manual tests #6433

fix #6379: beef up runtime styling manual tests #6433

incanus commented Sep 22, 2016

mention-bot commented Sep 22, 2016

incanus commented Sep 22, 2016 •

edited

Loading

1ec5 Sep 22, 2016 •

edited

Loading

incanus Sep 22, 2016

1ec5 Sep 22, 2016

incanus Sep 23, 2016 •

edited

Loading

1ec5 Sep 23, 2016 •

edited

Loading

incanus Sep 23, 2016

1ec5 Sep 22, 2016

incanus Sep 23, 2016

1ec5 Sep 22, 2016

incanus Sep 23, 2016

boundsj commented Sep 22, 2016

incanus commented Sep 23, 2016

incanus commented Sep 23, 2016 •

edited

Loading

boundsj commented Sep 23, 2016

incanus commented Sep 23, 2016

incanus commented Sep 23, 2016

fix #6379: beef up runtime styling manual tests #6433

fix #6379: beef up runtime styling manual tests #6433

Conversation

incanus commented Sep 22, 2016

mention-bot commented Sep 22, 2016

incanus commented Sep 22, 2016 • edited Loading

1ec5 Sep 22, 2016 • edited Loading

Choose a reason for hiding this comment

incanus Sep 22, 2016

Choose a reason for hiding this comment

1ec5 Sep 22, 2016

Choose a reason for hiding this comment

incanus Sep 23, 2016 • edited Loading

Choose a reason for hiding this comment

1ec5 Sep 23, 2016 • edited Loading

Choose a reason for hiding this comment

incanus Sep 23, 2016

Choose a reason for hiding this comment

1ec5 Sep 22, 2016

Choose a reason for hiding this comment

incanus Sep 23, 2016

Choose a reason for hiding this comment

1ec5 Sep 22, 2016

Choose a reason for hiding this comment

incanus Sep 23, 2016

Choose a reason for hiding this comment

boundsj commented Sep 22, 2016

incanus commented Sep 23, 2016

incanus commented Sep 23, 2016 • edited Loading

boundsj commented Sep 23, 2016

incanus commented Sep 23, 2016

incanus commented Sep 23, 2016

incanus commented Sep 22, 2016 •

edited

Loading

1ec5 Sep 22, 2016 •

edited

Loading

incanus Sep 23, 2016 •

edited

Loading

1ec5 Sep 23, 2016 •

edited

Loading

incanus commented Sep 23, 2016 •

edited

Loading