This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Clean up source-driven attribution #6465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since client code can readily access the individual sources, Map doesn’t need to expose a dedicated API for iterating over them.
This same notification can in the future be used for other changes to a source.
1ec5
added
refactor
Core
|
@1ec5, thanks for your PR! By analyzing this pull request, we identified @jfirebaugh, @tmpsantos and @incanus to be potential reviewers. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #6431 that addresses the feedback in #6431 (review). SDK code that wishes to display the style’s full attribution, such as MGLMapView in #5999, is now responsible for iterating over the style’s sources. The source attribution change notification has been generalized so that it can be reused in the future for other source changes.
/cc @jfirebaugh @tmpsantos