Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[android] add/remove Sprite Image #6513

Merged
merged 2 commits into from
Sep 30, 2016
Merged

[android] add/remove Sprite Image #6513

merged 2 commits into from
Sep 30, 2016

Conversation

ivovandongen
Copy link
Contributor

Fixes #6459

@ivovandongen ivovandongen added feature Android Mapbox Maps SDK for Android labels Sep 29, 2016
@ivovandongen ivovandongen added this to the android-v4.2.0 milestone Sep 29, 2016
@ivovandongen ivovandongen self-assigned this Sep 29, 2016
tobrun
tobrun approved these changes Sep 30, 2016
View reviewed changes
Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@ivovandongen ivovandongen changed the title [android] addImage / removeImage jni bindings [android] add/remove Sprite Image Sep 30, 2016
@ivovandongen ivovandongen mentioned this pull request Sep 30, 2016
Closed
@ivovandongen
Copy link
Contributor Author

Noting that there is an issue with updating sprites atm: #6536. But still this adds valuable functionality and I would like to go ahead and merge this.

@zugaldia / @tobrun

@ivovandongen ivovandongen merged commit ca20767 into master Sep 30, 2016
@ivovandongen ivovandongen deleted the 6459-add-image branch September 30, 2016 15:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tobrun tobrun tobrun approved these changes

Assignees

@ivovandongen ivovandongen

Labels
Android Mapbox Maps SDK for Android feature
Projects
None yet
Milestone
android-v4.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ivovandongen @tobrun @1ec5