Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[ios] Store annotation tags for MGLMultiPoint annotations in the map #6888

Merged
merged 2 commits into from
Nov 4, 2016

Conversation

boundsj
Copy link
Contributor

@boundsj boundsj commented Nov 3, 2016

This fixes an issue where, if a multipoint annotation was added, native annotation view update logic would crash. Adding the annotation tag for multipoints, too, avoids the out of range exception.

cc @1ec5 @incanus

This fixes an issue where, if a multipoint annotation was added,
native annotation view update logic would crash. Adding the annotation
tag for multipoints, too, avoids the out of range exception.
@boundsj boundsj added iOS Mapbox Maps SDK for iOS crash annotations Annotations on iOS and macOS or markers on Android release blocker Blocks the next final release labels Nov 3, 2016
@boundsj boundsj added this to the ios-v3.4.0 milestone Nov 3, 2016
@boundsj boundsj self-assigned this Nov 3, 2016
@mention-bot
Copy link

@boundsj, thanks for your PR! By analyzing the history of the files in this pull request, we identified @1ec5, @incanus and @friedbunny to be potential reviewers.

@boundsj
Copy link
Contributor Author

boundsj commented Nov 3, 2016

Sorry @1ec5, I just realized I missed adding the check for multipoints. Does not really change anything but I added it in f0039fd for consistency.

@boundsj boundsj merged commit 8afc68b into release-ios-v3.4.0 Nov 4, 2016
@boundsj boundsj deleted the boundsj-store-multipoint-tags branch November 4, 2016 01:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
annotations Annotations on iOS and macOS or markers on Android crash iOS Mapbox Maps SDK for iOS release blocker Blocks the next final release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants