This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Enable runtime styling tests on macOS #6889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
added
iOS
|
@1ec5, thanks for your PR! By analyzing the history of the files in this pull request, we identified @boundsj, @ituaijagbone and @frederoni to be potential reviewers. |
Moved MGLGeoJSONSourceTests and MGLTileSetTests into platform/darwin/test/ and added them to the macOS project. Also added a private header needed to compile the tests to the macOS project.
This header was missing from the project. The code was only compiling because the header was still on the search path.
Fixed an issue that caused the runtime styling API to return colors in the sRGB color space instead of the calibrated RGB color space.
Added the style layer tests to the test bundle target. Set the access token to a bogus access token before running any tests. The macOS implementation of MGLMapView doesn’t even attempt to set a default style if the access token is missing, because in macosapp, the access token may be set asynchronously by the user when the preferences window appears.
1ec5
force-pushed
the
1ec5-style-test-macos-5971
branch
from
43d4a2e to
a7edd0c
Compare
boundsj
approved these changes
Nov 3, 2016
|
This fixed #5971. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a few missing header references to the macOS project and shares the runtime styling unit tests between the iOS and macOS test target. Despite the headers being missing from the project, the SDK still compiled without errors because the headers were already in the header search path. If they had been public headers, the compiler might’ve issued a warning about an incomplete umbrella header or non-module include statement. Unless we decide to go ahead with #5942, we’ll just have to remain vigilant about private headers that fly under the radar.
The runtime styling API can now round-trip colors without losing accuracy. Previously, we were using one color profile when converting NSColor to
mbgl::Colorand another when converting back to NSColor.On macOS, we have to set the access token to a bogus access token before running any tests. The macOS implementation of MGLMapView doesn’t even attempt to set a default style if the access token is missing, because in macosapp, the access token may be set asynchronously by the user when the preferences window appears.
I’m targeting this PR against the release-ios-v3.4.0 branch because I intend to issue a macOS SDK release that’s as close to iOS SDK v3.4.0 as possible, and I want to ensure as much test coverage as possible.
/cc @frederoni @incanus