Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Cherry pick #7025 #7049

Merged
merged 1 commit into from
Nov 14, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/mbgl/tile/geometry_tile.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,12 @@ void GeometryTile::setData(std::unique_ptr<const GeometryTileData> data_) {
}

void GeometryTile::setPlacementConfig(const PlacementConfig& desiredConfig) {
if (placedConfig == desiredConfig) {
if (requestedConfig == desiredConfig) {
return;
}

++correlationID;
requestedConfig = desiredConfig;
worker.invoke(&GeometryTileWorker::setPlacementConfig, desiredConfig, correlationID);
}

Expand Down Expand Up @@ -112,7 +113,6 @@ void GeometryTile::onPlacement(PlacementResult result) {
buckets[bucket.first] = std::move(bucket.second);
}
featureIndex->setCollisionTile(std::move(result.collisionTile));
placedConfig = result.placedConfig;
observer->onTileChanged(*this);
}

Expand Down
3 changes: 1 addition & 2 deletions src/mbgl/tile/geometry_tile.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ class GeometryTile : public Tile {
public:
std::unordered_map<std::string, std::unique_ptr<Bucket>> buckets;
std::unique_ptr<CollisionTile> collisionTile;
PlacementConfig placedConfig;
uint64_t correlationID;
};
void onPlacement(PlacementResult);
Expand All @@ -79,7 +78,7 @@ class GeometryTile : public Tile {
Actor<GeometryTileWorker> worker;

uint64_t correlationID = 0;
optional<PlacementConfig> placedConfig;
optional<PlacementConfig> requestedConfig;

std::unordered_map<std::string, std::unique_ptr<Bucket>> buckets;
std::unique_ptr<FeatureIndex> featureIndex;
Expand Down
1 change: 0 additions & 1 deletion src/mbgl/tile/geometry_tile_worker.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,6 @@ void GeometryTileWorker::attemptPlacement() {
parent.invoke(&GeometryTile::onPlacement, GeometryTile::PlacementResult {
std::move(buckets),
std::move(collisionTile),
*placementConfig,
correlationID
});
}
Expand Down